GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.59k stars 139 forks source link

Ignoring with an until date is broken #873

Closed cyrvan-b closed 3 months ago

cyrvan-b commented 3 months ago

Context

Ggshield breaks when a vulnerability is ignored until a certain date.

Steps to reproduce

  1. Add a Pipfile and a Pipfile.lock with celery=4.4.7 as dependency
  2. Ignore by adding the following in .gitguardian.yaml
    - identifier: GHSA-q4xr-rc97-m4xx
      path: "Pipfile.lock"
      comment: "need to update code for compat"
      until: "2024-06-30T10:00:00"
  3. Run ggshield sca scan all
codecov-commenter commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 91.89%. Comparing base (26cac3c) to head (57abcec). Report is 16 commits behind head on main.

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #873 +/- ## ========================================== - Coverage 91.92% 91.89% -0.03% ========================================== Files 170 170 Lines 7058 7060 +2 ========================================== Hits 6488 6488 - Misses 570 572 +2 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/873/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/873/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `91.89% <100.00%> (-0.03%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.