Closed salome-voltz closed 1 month ago
Attention: Patch coverage is 66.66667%
with 5 lines
in your changes are missing coverage. Please review.
Project coverage is 91.81%. Comparing base (
372be8a
) to head (d7f1289
). Report is 63 commits behind head on main.
Files | Patch % | Lines |
---|---|---|
ggshield/cmd/auth/login.py | 42.85% | 4 Missing :warning: |
ggshield/core/url_utils.py | 85.71% | 1 Missing :warning: |
:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Context
ggshield auth login flow errors were not handled when instance URL is invalid.
What has been done
Error thrown are handled, similarly to how error are handled with
GITGUARDIAN_INSTANCE='https://dashboard.gitguardian.com/abc' ggshield auth login --method=token
Validation
Run the following commands:
GITGUARDIAN_INSTANCE='https://dashboard.gitguardian.com/abc' ggshield auth login
GITGUARDIAN_INSTANCE='https://dashboard.example.com' ggshield auth login
Note
This also fixes the following issue: #892![image](https://github.com/GitGuardian/ggshield/assets/80842312/73b0c9b8-3bfc-4acf-96d9-dff72e33c26f)
PR check list
skip-changelog
label has been added to the PR.