GitGuardian / ggshield

Find and fix 400+ types of hardcoded secrets and 70+ types of infrastructure-as-code misconfigurations.
https://gitguardian.com
MIT License
1.65k stars 147 forks source link

Mmillet/sca 1670 refactor ggshield scan ci commands #902

Closed gg-mmill closed 3 months ago

gg-mmill commented 4 months ago

Context

Refactor sca scan ci and iac scan ci: we want to

What has been done

Refactor the commands

Validation

Run the commands in merge request pipelines, with verbose mode.

PR check list

codecov-commenter commented 4 months ago

Codecov Report

Attention: Patch coverage is 69.41176% with 26 lines in your changes missing coverage. Please review.

Project coverage is 91.32%. Comparing base (372be8a) to head (cd9c929). Report is 69 commits behind head on main.

Files Patch % Lines
ggshield/cmd/iac/scan/ci.py 14.28% 12 Missing :warning:
...shield/core/git_hooks/ci/get_scan_ci_parameters.py 75.51% 12 Missing :warning:
ggshield/cmd/sca/scan/ci.py 86.66% 2 Missing :warning:

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #902 +/- ## ========================================== - Coverage 91.67% 91.32% -0.35% ========================================== Files 170 173 +3 Lines 7060 7181 +121 ========================================== + Hits 6472 6558 +86 - Misses 588 623 +35 ``` | [Flag](https://app.codecov.io/gh/GitGuardian/ggshield/pull/902/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | Coverage Δ | | |---|---|---| | [unittests](https://app.codecov.io/gh/GitGuardian/ggshield/pull/902/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian) | `91.32% <69.41%> (-0.35%)` | :arrow_down: | Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=GitGuardian#carryforward-flags-in-the-pull-request-comment) to find out more.

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.