search

GitHawkApp / ContextMenu

An iOS context menu UI inspired by Things 3.
http://githawk.com/
MIT License
982 stars 51 forks source link

Use UIView.TintAdjustmentMode #34

Open ivan-magda opened 6 years ago

ivan-magda commented 6 years ago

Hey, @rnystrom

I think it would be nice to update tintAdjustmentMode like Apple UI controls do. If you wish I can create a PR, just two lines of code:

ezgif com-resize

rnystrom commented 5 years ago

Scratching my head, what’s he difference? What value does this add? I’m not familiar with the API.

Sent with GitHawk

av0c0der commented 5 years ago

@rnystrom seems like you didn't note how the color of UIBarButtonItems have changed? .dimmed tint mode makes them black & white, this API is used in UIAlertController.

rnystrom commented 5 years ago

@Jauzee what do you mean about the color change?

av0c0der commented 5 years ago

@rnystrom I meant tint color of the buttons on the gif.

rnystrom commented 5 years ago

Oh now I see it! TIL that’s a thing. I’m down with offering this as an optional config.

Sent with GitHawk

av0c0der commented 5 years ago

@rnystrom one thing to note here — if we apply tintAdjustmentMode on the key window it will apply it on the presented view controller's subviews too.

I've also read about this API just a few weeks ago. :)