GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 385 forks source link

Check if the version is up-to-date when reporting a bug to GitHawk #1194

Open BasThomas opened 6 years ago

BasThomas commented 6 years ago

Possibly blocked by #735. Followup from #1189:

Would be cool if we can have a check somewhere (either in-app - before submitting a bug report - or in the GitHub issue) checking if the version is out-of-date automatically!

Maybe a little warning box above the form content? Similar to how GitHub desktop gives you the prompt to check the contributing guide etc?

Yes, and then we can do a version comparison through the iTunes API (this endpoint). Would obviously have to ignore a higher version (as can happen w/ TF), but that should help 👍

We can probably just toss up a Toast to inform the user blocked by #735.

We should check when you report via Settings or via Repo search in the GitHawk repo. Should find a safe way to check if it is indeed this repo (would be nice if this would continue to work even if we move the repo to an organisation for example).

This should also ignore / not show an error if you are on a new version than the App Store (eg. when using TestFlight).

Sherlouk commented 6 years ago

tbh, what's stopping us doing something like this for just opening the app? #1180 but for "pls update" or is that too much?

BasThomas commented 6 years ago

I think that would be too much - at least for me. This still lets the user decide (without interupting them) and only show it when it can “hurt” us / cost us time (in case of outdated bugs). In the future, we can always look at something like that! I can imagine this might be something we’d like to do when eg. 2.0 comes out.

Sent with GitHawk