search

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 383 forks source link

Comments render white space #1339

Closed BasThomas closed 6 years ago

BasThomas commented 6 years ago

GitHawk Upload by BasThomas

Happens on both iPad and iPhone. Have a feeling it’s been happening more the last few days? Also happened on previous version though.

Bug Report Dump (Auto-generated) 
Version 1.17.0 (1514903367)
Device: iPad7,3 (iOS 11.2.1)
TestFlight: true
BasThomas commented 6 years ago

Issue in question: https://github.com/Moya/Moya/issues/1523

Sent with GitHawk

rnystrom commented 6 years ago

Hmm @BasThomas can you do some debugging here? I can't repro.

SD10 commented 6 years ago

The spacing is even larger in the latest TestFlight: 1.17.0

I think it’s also making scrolling extremely choppy.

GitHawk Upload by SD10

Sent with GitHawk

BasThomas commented 6 years ago

Haven’t seen it lately - can you tap with three fingers to dig a bit with FLEX?

Sent with GitHawk

SD10 commented 6 years ago

Sorry @BasThomas I don’t know what you mean.

It’s difficult to reproduce but once it happens, any comments have an excessive amount of spacing on any issue throughout the app. Once I kill GitHawk and reopen it’s gone.

It has happened by viewing an issue on a fresh app start, expanding a comment, posting a comment. Can’t single it down to one specific action and it’s inconsistent.

Sent with GitHawk

BasThomas commented 6 years ago

In Testflight, you can tap with three fingers anywhere on the screen to have additional tools (see image), which enable you to debug the views, network requests and more.

GitHawk Upload by BasThomas

Sent with GitHawk

SD10 commented 6 years ago

Sorry @BasThomas, noob moment. Thanks for getting me up to speed!

Sent with GitHawk

BasThomas commented 6 years ago

@SD10 have you been seeing it in the last few days / been able to debug with FLEX?

SD10 commented 6 years ago

I haven't seen any but I've had very limited GitHub activity in the past few days. We could close and re-open if I see it again

rnystrom commented 6 years ago

I think I saw this today caused by html comments and no actual content. Will investigate.

Sent with GitHawk

Sherlouk commented 6 years ago

https://github.com/SwifterSwift/SwifterSwift/pull/364

Not sure if the same bug, but the root comment in here has a bunch of HTML comments which render as massive blocks of white space in app

SD10 commented 6 years ago

Steps to reproduce:

  1. Open any issue / PR
  2. Immediately stop view from scrolling to bottom
  3. White space appears on all comments made through GitHawk and other HTML blocks

Sent with GitHawk

rnystrom commented 6 years ago

@SD10 hmmm I can’t seem to repro that. The html comments are definitely a thing though. I’m going to fix those for 1.17

Sent with GitHawk

rnystrom commented 6 years ago

PR fixes this big time, but still want to strip commented HTML out. For example, that Moya issue is totally empty.

rnystrom commented 6 years ago

Seems to be fixed