search

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 382 forks source link

Allow users to see closed milestones #1469

Open SD10 opened 6 years ago

SD10 commented 6 years ago

Currently, I’m only able to see the open milestones when trying to assign an issue. I have some old issues that belong to a previous milestone and I would like to be able to access them as well.

I’m thinking maybe a UISegmentedControl can be added to toggle between open and closed milestones.

Sent with GitHawk

rnystrom commented 6 years ago

Iiiiinteeresting. Only now noticed that you can access closed milestones. I think a simple segmented control would be a fantastic solution.

Though before we do that, I think we should first refactor Milestones, Labels, and Assignees to use BaseListViewController + IGListKit so we can get paging, empty states, and static controls (e.g. the seg control) "for free". Not to mention align these surfaces w/ a similar architecture used throughout the app.

See #1463 and #1026

@SD10 if you want to take any of this on I'd be 🙏 and accept any PRs!

SD10 commented 6 years ago

I’m a little overwhelmed at the moment but I want to contribute in the future. If anyone gets to this before me feel free

Sent with GitHawk

SD10 commented 6 years ago

@rnystrom I'll take care of this refactor over the next couple days if you'd like? A little bit of a learning curve for me because I don't use IGListKit 😅 I'll just use the existing controllers as inspiration