App accounts open as user accounts, which 404

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.

http://githawk.com

MIT License

2.88k stars 385 forks source link

App accounts open as user accounts, which 404 #159

Open BasThomas opened 7 years ago

BasThomas commented 7 years ago

Version: 1.2.0 (910) Device: iPad Pro (iOS 10.3.2)

Eg. https://github.com/Moya/Moya/issues/703#issuecomment-315715807. Theprobot-stale account opens https://github.com/probot-stale instead of https://github.com/apps/probot-stale.

rnystrom commented 7 years ago

I’ll have to go through the docs and see if I can distinguish an app user and a normal user. Should be doable?

Sherlouk commented 7 years ago

@rnystrom Don't think there's a way to directly check if they're an app/normal user, but the "Actor" object does have a "URL". Haven't checked, but I'll assume we need to use that URL over trying to create one ourselves from the login name

https://developer.github.com/v4/reference/interface/actor/