GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 384 forks source link

Write a review icon fades gray after highlight #2055

Open Huddie opened 6 years ago

Huddie commented 6 years ago

If this is to denote “clicked” maybe we switch it to after the cell was selected instead of highlighted

Bug Report Dump (Auto-generated)
Version 1.22.0 (1533487686)
Device: iPhone 6s (iOS 11.4.1)
TestFlight: true
rnystrom commented 6 years ago

🤔 can you explain this a bit more? The cell should have a selection state. What’s the actual issue here?

Sent with GitHawk

Huddie commented 6 years ago

So if you were to press the cell but not click it.

  1. Press cell (but don’t click it)
  2. Move finger off cell.

The icon turns gray as if you had actually pressed it.

Not major on the least bit but I assume it’s a quick fix. I can look into it.

Sent with GitHawk

rnystrom commented 6 years ago

Oh ya that’s just the cell highlight state. Pretty typical UX of iOS apps

Sent with GitHawk

Huddie commented 6 years ago

@rnystrom Looking at the settings VC it seems that its caused by the image being set to render as template and the tint color being set to a gray.

Not sure why it doesn't render gray in the beginning.

rnystrom commented 6 years ago

Oh strange, it’s always gray to me

Sent with GitHawk

Huddie commented 6 years ago

Here’s what I get. Doesn’t really make a difference but just thought I’d log it so it’s known.

GitHawk Upload by Huddie

Sent with GitHawk

rnystrom commented 6 years ago

@Huddie do you have some accessibility options enabled? Why do your switches have extra icons? iOS 11.4?

Sent with GitHawk

Huddie commented 6 years ago

@rnystrom Ya I have the accessibility for switches. Idk I kinda like it. Is that what’s causing it? And yes iOS 11.4.1

Sent with GitHawk

rnystrom commented 6 years ago

I’m not sure tbh

Sent with GitHawk

BasThomas commented 6 years ago

Settings > General > Accessibility > On/Off Labels. Supported by all UISwitches. Been there since iOS 7 I think?

Huddie commented 6 years ago

I turned it off , didn’t change anything. Not sure if that helps.

Sent with GitHawk

BasThomas commented 6 years ago

Don't think that is related

rnystrom commented 6 years ago

We need a "bug?" label