Dis/Approve pull requests

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.

http://githawk.com

MIT License

2.88k stars 382 forks source link

Dis/Approve pull requests #2137

Open moimikey opened 6 years ago

moimikey commented 6 years ago

would be nice to be able to also approve or disapprove prs. I can do everything except for that.

Bug Report Dump (Auto-generated)

Version 1.22.0 (1534395229)
Device: iPhone X (iOS 11.4.1)
TestFlight: false

rnystrom commented 5 years ago

Aaaaaaabsolutely. The next update I want to get these local pushes working, then focus on a PR-rich update.

_{Sent with GitHawk}

flovilmart commented 5 years ago

@rnystrom I will have some time to jump on that. I recenlty changed my github workflow to 100no emails :)

moimikey commented 5 years ago

yey

flovilmart commented 5 years ago

@rnystrom did you have anything in mind for the positioning of such actions?

I am futzing with multiple options:

From the menu (with labels and milestones) add Approve / Reject
From the menu add 'Add Review' which pushes a new controller with a textView + MergeButton (customized)
From the files list

etc...

peterdemartini commented 5 years ago

What is the status of this feature? If I can weight in on the location, it would be really cool to be able to see the “Add review” button in place of the “Not authorized to merge” when there is a missing but required review. Additionally I think it would be natural to add this to the files view to keep it consistent with github’s process.

flovilmart commented 5 years ago

I barely I started with playing with the code. The task is quite daunting when you consider all the cases. I’ll hopefully have time to look at it soon

_{Sent with GitHawk}

Huddie commented 5 years ago

Woah! This would be awesome 👏

_{Sent with GitHawk}

jonsch commented 4 years ago

is this feature request still planned?

leecalcote commented 4 years ago

Approving a PR was the first task I needed to do when downloading and opening githawk a few minutes ago. Looks like a great app, but the lack of the ability to do PR review has me downloading another app.

moimikey commented 4 years ago

@leecalcote also given I requested it in 2018 and we're in 2020 now. :(

sfdye commented 4 years ago

Bump, as a open source project maintainer this feature is greatly needed

flovilmart commented 4 years ago

I won’t have time to work on this, unassigning myself