Can’t comment

[djbe]

I’m able to view issues and PRs, lock them, assign milestones, etc... But I can’t send comments that I write. I get a double tap haptic feedback, but my comment isn’t posted.

Bug Report Dump (Auto-generated)

Version 1.23.0 (1538537771)
Device: iPhone 7 (iOS 11.4.1)
TestFlight: true

[BasThomas]

Is there an error toast that pops up? Or can you check the result of the networking call (three finger tap on the screen to open FLEX debugging)?

[djbe]

No toast. Trying this from inside GitHawk.

_{Sent with GitHawk}

[djbe]

Huh, that works, wth

_{Sent with GitHawk}

[djbe]

Right so the toast was hidden behind the keyboard. This is the JSON response:

  "data" : {
    "addComment" : null
  },
  "errors" : [
    {
      "path" : [
        "addComment"
      ],
      "message" : "Although you appear to have the correct authorization credentials,\nthe `SwiftGen` organization has enabled OAuth App access restrictions, meaning that data\naccess to third-parties is limited. For more information on these restrictions, including\nhow to whitelist this app, visit\nhttps://help.github.com/articles/restricting-access-to-your-organization-s-data/\n",
      "type" : "FORBIDDEN",
      "locations" : [
        {
          "line" : 2,
          "column" : 3
        }
      ]
    }
  ]
} ```

<sub>Sent with <a href="http://githawk.com">GitHawk</a></sub>

[djbe]

So the issues maybe are: hide the keyboard on error, so users can see the error, and maybe show that specific error from github?

_{Sent with GitHawk}

[BasThomas]

I think we have a ticket somewhere to show the toast above the keyboard.

[mesqueeb]

I’m not sure if the is related but since the latest Testflight beta the notifications work but i cannot comment anymore.

With keyboard I the no toast and without keyboard it just says "something went wrong"

[Huddie]

@mesqueeb “Something went wrong” is the generic error but I think there’s an issue for that as well

_{Sent with GitHawk}