Bringing templates to GitHawk

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.

http://githawk.com

MIT License

2.88k stars 382 forks source link

Bringing templates to GitHawk #2393

Open Huddie opened 5 years ago

Huddie commented 5 years ago

Working on this, if anyone has ideas or suggestions please lmk!

rnystrom commented 5 years ago

Yo this is so cool!! Would this work for the “new issue” feature in repos too?

_{Sent with GitHawk}

Huddie commented 5 years ago

@rnystrom I’m almost positive! I checked github and all issues are under .github/ISSUE_TEMPLATE

Right now I fetch for specific files but my end plan is fetch all files under that directory, parse the text for the name / description

Should work for all repos!

_{Sent with GitHawk}

Huddie commented 5 years ago

I’ll keep this thread updated with progress

_{Sent with GitHawk}

Huddie commented 5 years ago

@rnystrom Confirmed that it will work across the board. Done for the night 🌙

Sherlouk commented 5 years ago

https://github.com/GitHawkApp/GitHawk/issues/404

Just gonna link the original ticket for this before GitHub added different template options, maybe no point in supporting the old one if most people have moved to this new system?

Huddie commented 5 years ago

@Sherlouk the old one being in root/docs/.github rather than strictly .github? I’m not so familiar with github templates, searching online It seemed that you could have as many templates as you want but must be in .github/ISSUE_TEMPLATE directory. Is this not true, can you have templates in other places? Quick note: I’m speaking specifically about issue templates not PR templates

I think for now it’s fine to support this way as if no templates are found it simply opens up the new issue view like it used to. We can expand to support other templates in the future, if others exist.

_{Sent with GitHawk}

Sherlouk commented 5 years ago

@Huddie Yea so I think the difference is with the new system you can have multiple named templates but previously you could have a single template that was called ISSUE_TEMPLATE.md (and could be in a multitude of places) and would always use that one.

Essentially I think the chain of logic is:

Check for templates in .github/ISSUE_TEMPLATE/ directory
Check for single template called ISSUE_TEMPLATE.md in either root or .github (name not case sensitive)
Just leave it empty

I think for the sake of this, just doing that first one is definitely great progress!

Huddie commented 5 years ago

Thanks @Sherlouk I will PR number 1 and then maybe expand after that.

_{Sent with GitHawk}

ijm8710 commented 5 years ago

Really cool!!!

ijm8710 commented 5 years ago

Me: Curious, so the way it works is to provide a framework on what you’re reporting? Is it the user’s job to replace the template with their report? Is there any way to set it up so it prompts you, this is what you enter here without the need to delete? This is super cool either way but was just curious so that the template is still a reference but also streamlines the input

Huddies reply to me: if you could move this comment to #2393 this thread is more for the release of the feature, that thread is about the feature itself. Quick answer is, templates are a Github thing so we are mimicking the feature as much as possible. No fill ins etc. Just a template of what to write. Unfortunately that means deleting text.

Huddie commented 5 years ago

It could be one day we expand the feature natively

ijm8710 commented 5 years ago

Yeah understood this is more baseline and it seems awesome. Was just curious if you were on same page as me that this would even have more utility with my suggestion and it sounds like over time it could add a little value. Thanks for the reply and the work!

superandrew commented 4 years ago

this is so cool! is it still on the works? or is it available already in some distribution/beta testing of the app?