[VISION] Pull Requests - Githubissues

Huddie commented 6 years ago

The theme seems to be these [VISION] issues rather than projects.

I think we can make pull requests awesome in GitHawk, I just want to compile a bunch of scattered issues that are still open that would make this happen.

[ ] We do not show all PR comments/replies. This means using the app to review pull request is almost impossible after you've passed the limit of the number of comments we show. #1760
[ ] Displaying code could be enhanced #2136
[ ] Add ability to review a PR #2061
[ ] Add ability to Approve/Disapprove PR's #2137. Possibly in the manager button.
[ ] Add ability to delete branch after merge #1542
[ ] Add reactions to review comments #1547
[ ] Add option to warn user about to merge a PR marked WIP (see below)
[ ] Creating a pull request in-app #1796. We can generalize the new feature banner #2473 and use that to inform users of a possible new pull request to create.

I think compiling related issues is a great idea for productivity. Let me know if I missed issues.

Sherlouk commented 6 years ago

Random idea, but maybe we could block out the "Merge Pull Request" button if the title has WIP: or something similar in the name? (Something more used on GitLab admittedly but I quite like it)

Huddie commented 6 years ago

@Sherlouk maybe have that as an option?

_{Sent with GitHawk}

Huddie commented 5 years ago

@Sherlouk instead of blocking it out maybe just warn the user “this pull request seems to be marked as a work in progress, are you sure you want to merge”

_{Sent with GitHawk}

BasThomas commented 5 years ago

Random idea, but maybe we could block out the "Merge Pull Request" button if the title has WIP: or something similar in the name? (Something more used on GitLab admittedly but I quite like it)

Guess with drafts we do not need this anymore :-)

GitHawkApp / GitHawk

[VISION] Pull Requests #2496