GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 384 forks source link

Crash when opening large file diff within PR #2879

Closed 06needhamt closed 4 years ago

06needhamt commented 4 years ago

Describe the bug App hangs and crashes when opening a large diff within the PR changes view

To Reproduce Steps to reproduce the behavior:

  1. Go to This PR
  2. Open Changed files
  3. Click on 'CSharpResources.Designer.cs'
  4. Wait approx 30 seconds
  5. App crashes without an error

Expected behavior Expected the file diff to open and display normally

Screenshots unnamed

Smartphone (please complete the following information):

Additional context Small diffs seem to open as expected only large diffs (over 5000) lines seem to be affected.