GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 382 forks source link

Please kill the “Sent with GitHawk” signature #2910

Open chris-morgan opened 4 years ago

chris-morgan commented 4 years ago

Signatures in general are a terrible thing. “Sent with ___” signatures are even worse. They clog up space and search results and distract, providing information that literally no one needs to know (exactly zero people in the entire universe), and roughly no one even wants to know. Please, please kill them. Don’t make them optional, default off (I have no idea whether they’re optional already or what the default may be), just kill them with fire. They’re a serious misfeature.

The fact that you chose to replace the signature with a badge in GitHawk is a fair indication that people won’t like the signature.

If you really want the ability to put a badge in your own client (which I think is silly, but if you really want to you can), put it as an HTML comment, e.g. <!-- Sent with GitHawk --> or <!-- User-Agent: GitHawk x.y.z -->, and seek that in your app. That way you’ll only be harming GitHub’s text/plain emails and searchability for both email and web, not GitHub’s web interface display and text/html emails.

I just saw my first one. It irritated me enough to create this issue. I wondered whether someone else had created any similar issue, but naturally found the matter completely unsearchable until I resorted to looking up the syntax in:title—because more than half of the issues contain that very string, as pure noise! And such a title search may then miss matches that just didn’t use that phrase in the title.

Sherlouk commented 4 years ago

I have no idea whether they’re optional already or what the default may be

They can be controlled on/off through the settings page - defaulted to on.

It is worth noting that the app is now essentially deprecated in favor of the official GitHub mobile app.

The GitHawk signature was great for promoting the app and getting the word out - so it serves it's purpose fairly well but understand your points when it comes to searching.