search

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 385 forks source link

Buggy selecting #341

Closed BasThomas closed 6 years ago

BasThomas commented 7 years ago

Version 1.10.0 (1878) Device: iPhone 7 Plus (iOS 11.0)

Video: (ugh, I can’t add video on GH 😔) https://www.icloud.com/sharedalbum/#B0LG6XBubG3PB4W

rnystrom commented 7 years ago

@BasThomas what’s the bug here?

Sent with GitHawk

BasThomas commented 7 years ago

When selecting something, more is selected than should. Try it by manually selecting a piece of text when writing a comment and changing it. It will often select some characters to the left as well. A bug in Slack’s implementation probably?

BasThomas commented 7 years ago

Yeah, it’s a bug in the Slack thing. Ughhh

rnystrom commented 7 years ago

I've hacked at their control already, we can mess it up more (not included as a CocoaPod for this reason)

BasThomas commented 7 years ago

Filed at https://github.com/slackhq/SlackTextViewController/issues/622

Sent with GitHawk

rnystrom commented 7 years ago

Side note, this text view control looks like abandonwear...

BasThomas commented 7 years ago

Oh noes! Weird; they still use it in Slack as well. 😞

BasThomas commented 7 years ago

OK so this also seems to happen to me in Messages.app. I think it might be an Apple bug. 😱

Sent with GitHawk