Mixed search results - Githubissues

GitHawkApp / GitHawk

The (second) best iOS app for GitHub.

http://githawk.com

MIT License

2.88k stars 384 forks source link

Open rnystrom opened 7 years ago

rnystrom commented 7 years ago

Expand search to issues and users. Options:

Mixed results. Show top 4-5 results for repo/user/issue. Simpler impl, easy UX, but limited results. Maybe have a “show more” cell?

Seg control (scope API on search bar). Worse UX (have to tab) but shows a lot more results.

I lean towards mixed. Thoughts?

BasThomas commented 7 years ago

Mixed feels like the way to go for sure imho.

Sherlouk commented 7 years ago

Using V3 APIs (https://developer.github.com/v3/search/#search-commits) there's actually quite a few other options we can do also

rnystrom commented 7 years ago

Proooobably want to keep it simple to start. Can expand once there's demand.

Sherlouk commented 7 years ago

Definitely wasn't suggesting we do it all now 😅 Just saying what we could do

jdisho commented 6 years ago

Suggestion: On searchBarTextDidEndEditing, show two options what to search.

What do you think? @rnystrom

Btw, this issue has a high priority since November. Are we planning to implement it soon?