GitHawkApp / GitHawk

The (second) best iOS app for GitHub.
http://githawk.com
MIT License
2.88k stars 385 forks source link

GitHub check lists #50

Closed dkhamsing closed 6 years ago

dkhamsing commented 7 years ago
rnystrom commented 7 years ago

Current:

img_4535 png

Sherlouk commented 7 years ago

I see three stages that need to be done, and only the first can be done for now Sometimes wish iOS has a checkbox control

BasThomas commented 7 years ago

Luckily, there's OSS ☺️

https://github.com/Boris-Em/BEMCheckBox https://github.com/Marxon13/M13Checkbox

rnystrom commented 7 years ago

I bet other repos would just complicate things, I envision:

BasThomas commented 7 years ago

Oh, didn't think of emoji. Nice one! Is there an emoji for an empty checkbox though? I can't find one.

rnystrom commented 7 years ago

Ha, I figured there was, but maybe not 😞

This would be lame, but maybe ⬜️ ?

Otherwise we'll have to do text location finding, could be a huge PITA 😬

Sherlouk commented 7 years ago

Bit shit but with a large font size:

β˜‘οΈŽβ˜’β˜

dzenbot commented 7 years ago

What about icon fonts?

dkhamsing commented 7 years ago

https://github.com/dzenbot/Iconic :)

shaps80 commented 7 years ago

You could use a subclassed NSTextAttachment in the NSAttributedString. With a little bit of code, its possible to allow any arbitrary UIView.

That way you can still keep the string, but create a custom view easily. (or even use a UISwitch or whatever makes sense)

Out of the box, only image attachments are supported, but if you google a little you'll find simple examples for how to achieve this. No need to import a 3rd party lib.

EDIT: Quick note, your custom attachment would NOT participate in selections, i.e. copied text will not include the attachment. You could obviously get around this by overriding the copy command and putting back the original [x] if you wanted. Currently however the app doesn't support this behaviour anyway.

rnystrom commented 6 years ago

Closing as this is working, filing a new issue for interactivity