Open eliburke opened 6 years ago
All great questions! And ones that I havenāt put a lot of thought into. Iāll try to work on a vision doc sometime to express my thoughts.
Itās definitely not a total STVC replacement yet. There are missing features like edit mode and left buttons. But for a simple resizing text view for messaging, this is pretty much all you need.
I donāt plan on adding any messaging functionality to this project as I think that implementing table or collection views should be completely decoupled from an input text view (prob my biggest gripe with STVC).
Really great questions, Iām glad you asked!
Sent with GitHawk
Love this project already, love this issue too. I was looking for a lightweight replacement for slacktextviewcontroller. Will be interested to see the vision for the project! <3
@eliburke If you are looking for something with more buttons/functionality I suggest you take a look at my repo https://github.com/nathantannar4/InputBarAccessoryView It is what we use at MessageKit
I agree with Ryan in that Table/Collection View should be separate as they shouldn't depend on each other
@nathantannar4 InputBarAccessoryView looks great - so why doesn't this project leverage that work considering you are a collaborator on this project? If I use InputBarAccessoryView now for the extra buttons functionality that I need, will I be wanting to migrate across to MessageViewController in a few months when that's added here in this project? I also need an edit mode, so if I develop that, which project is most likely to take a merge request?
@enhancient both had different beginnings. I started mine for MessageKit and Ryan did his for GitHawk. Ryan has many more followers than me though so this library gained a large following quickly so I wanted to contribute with something I would find useful in GitHawk.
Aside from different origin stories, both have quite different architectures. MessageViewController
is a UIViewController
subclass where was InputBarAccessoryView
is an InputAccessoryView
.
Ryan is really nice about PRs and I'm happy to have one on mine to. If you had to make a choice between the two you would have to look at what you project needs and which is better for it.
Sent with GitHawk
@nathantannar4 thanks, that's useful š
As a heavy user of SlackTextViewController, I came here immediately after reading about your project in iOS Dev Weekly. The goal is ambitious: "A SlackTextViewController replacement written in Swift for the iPhone X." Sounds fantastic, but the reality isn't up to the hype quite yet š
I'm not trying to be an ass; what you have so far looks great. Could you maybe update the home page or comment on this issue to give some more details on what you hope to accomplish? The version number is pretty low so I imagine it is a work in progress. Do you see this as a total replacement for STVC and the majority of its features or is it more narrowly focused? Is more of the messaging-related functionality in GitHawk going to be migrated into MessageViewController? Do you have a roadmap in mind for things like input buttons / toolbar, typing indicator, Edit mode, gestures, animations? Are you looking for contributors or do you intend to get closer to a 1.0 release before you open it up more?
-Eli