relative url's for image in CSS is changed

GitHubLeoYeh / granule

Automatically exported from code.google.com/p/granule

0 stars 0 forks source link

relative url's for image in CSS is changed #3

Closed GoogleCodeExporter closed 8 years ago

GoogleCodeExporter commented 8 years ago

What steps will reproduce the problem?
1.create css class in any css file with background image in it with relative url
2.use granule tag to combine with cssfastmin method 
3.in combine.css the relative url is changed style/..

What is the expected output? What do you see instead?
relative url in css class does not change

What version of the product are you using? On what operating system?
1.0.7

Please provide any additional information below.

Original issue reported on code.google.com by ashaagga...@gmail.com on 9 May 2011 at 6:47

GoogleCodeExporter commented 8 years ago

I can not change the url to absolute , the images are hosted on different 
server so they are called as //www... if I change them to http://www then 
issues comes with secure url "https//www..

Original comment by ashaagga...@gmail.com on 9 May 2011 at 6:49

GoogleCodeExporter commented 8 years ago

Yes, we do fixing the relative urls. CSS files might be located on the 
different levels and combined css is always on the top. Probably there are case 
when we are fixing them wrong. Can you send more information:
-Relative location of your css file
-Original relative URL in css filed.
-Final URL in the combined css.

Original comment by Jonathan...@gmail.com on 9 May 2011 at 10:19

GoogleCodeExporter commented 8 years ago

location of css file is - /web-app/styles/mycssfile.css
Original relative URL in css file 
background:url('//mydomain.com/images/test.png')
Final URL in the combined css 
background:url('styles/mydomain.com/images/test.png')

Original comment by ashaagga...@gmail.com on 9 May 2011 at 11:10

GoogleCodeExporter commented 8 years ago

Thanks. It will be fixed soon.

Original comment by Jonathan...@gmail.com on 9 May 2011 at 11:30

Changed state: Accepted

GoogleCodeExporter commented 8 years ago

Thank you for your quick response!! appreciated a lot!

Original comment by ashaagga...@gmail.com on 9 May 2011 at 11:44

GoogleCodeExporter commented 8 years ago

Fixed in 1.0.9

Original comment by Jonathan...@gmail.com on 10 May 2011 at 4:00

Changed state: Fixed

GoogleCodeExporter commented 8 years ago

Fixed in 1.0.9

Original comment by Jonathan...@gmail.com on 10 May 2011 at 4:01

GoogleCodeExporter commented 8 years ago

Thank you, 1.0.9 fixed the issue

Original comment by ashaagga...@gmail.com on 10 May 2011 at 4:44

GoogleCodeExporter commented 8 years ago

using 1.0.9 the issue still exists if paths are not absolute.

Original comment by naiadigi...@gmail.com on 2 Aug 2011 at 10:12

GoogleCodeExporter commented 8 years ago

https://github.com/JonathanWalsh/Granule/commit/55e58b5eef399f950a0f18ffd2c8eb75
37c031a5#commitcomment-694663

Original comment by IgorLych...@gmail.com on 8 Nov 2011 at 7:58