GitHubRGI / swagd

New development has moved to GitLab
https://gitlab.com/GitLabRGI/swagd
MIT License
3 stars 1 forks source link

Geopackage features #359

Closed LukeL-dev closed 8 years ago

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-27.1%) to 59.11% when pulling 77dd381449b308a98d4f46acde3c67f0218e2363 on geopackage-features into 9d1df7abacf538ad4eabf5cabcf0172476cdeb51 on master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-27.1%) to 59.11% when pulling 6992968a5cabd997d68fd3ef07d6d9eff64a969d on geopackage-features into 9d1df7abacf538ad4eabf5cabcf0172476cdeb51 on master.

stevendlander commented 8 years ago

In TestUtility.java%getRandomFile(), you can set testFile.deleteOnExit() and just get rid of TestUtility.deleteFile() altogether, along with all the calls to that function in the Geopackage tests. See here for more info:

https://docs.oracle.com/javase/7/docs/api/java/io/File.html#deleteOnExit()

stevendlander commented 8 years ago

In TestUtility, the package imports are unnecessary.

stevendlander commented 8 years ago

In WkbCurvePolygonZM fix type-o pending implementaiton

stevendlander commented 8 years ago

What is NetworkUtility.java for? Testing networks? Does it need to remain in source?

stevendlander commented 8 years ago

Code has been reviewed as best as I could. Some test files were ignored since I assume the build will check if they are correct or not.

How do you plan on merging this? Have you merged master into this branch in a while? I will have to disable test coverage thresholds on Coveralls for a while until your tests are done and we are back up to ~86% coverage again.

LukeL-dev commented 8 years ago

Added testFile.deleteOnExit()

LukeL-dev commented 8 years ago

Removed unnecessary TestUtility package imports

LukeL-dev commented 8 years ago

Fixed implementaiton typos

LukeL-dev commented 8 years ago

Removed NetworkUtility

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-25.8%) to 60.464% when pulling 679bcffc4a77045cfc9e71517c31c899535accc7 on geopackage-features into a346e274a1d378cda25ea53bde0b230814c19941 on master.