Closed LukeL-dev closed 8 years ago
In TestUtility.java%getRandomFile()
, you can set testFile.deleteOnExit()
and just get rid of TestUtility.deleteFile()
altogether, along with all the calls to that function in the Geopackage tests. See here for more info:
https://docs.oracle.com/javase/7/docs/api/java/io/File.html#deleteOnExit()
In TestUtility
, the package imports are unnecessary.
In WkbCurvePolygonZM
fix type-o pending implementaiton
What is NetworkUtility.java
for? Testing networks? Does it need to remain in source?
Code has been reviewed as best as I could. Some test files were ignored since I assume the build will check if they are correct or not.
How do you plan on merging this? Have you merged master into this branch in a while? I will have to disable test coverage thresholds on Coveralls for a while until your tests are done and we are back up to ~86% coverage again.
Added testFile.deleteOnExit()
Removed unnecessary TestUtility package imports
Fixed implementaiton
typos
Removed NetworkUtility
Coverage decreased (-27.1%) to 59.11% when pulling 77dd381449b308a98d4f46acde3c67f0218e2363 on geopackage-features into 9d1df7abacf538ad4eabf5cabcf0172476cdeb51 on master.