search

GitHubSecurityLab / actions-permissions

GitHub token permissions Monitor and Advisor actions
MIT License
233 stars 18 forks source link

GitHub Enterprise Support #8

Closed martincostello closed 19 hours ago

martincostello commented 1 year ago

I was taking a look at the actions with a view to maybe trying them out in GitHub Enterprise Server, but it seems that the actions assume running in github.com in a few places (example).

If the GITHUB_API_URL, GITHUB_GRAPHQL_URL and GITHUB_SERVER_URL environment variables were inspected when building up the list of hosts/URLs to inspect requests to then I would have thought it would then theoretically work.

JarLob commented 1 year ago

Good point, thank you for you feedback! If you could try applying the changes and try it with GHE (you can use - uses: martincostello/actions-permissionsmonitor@your_branch) I would merge that!

martincostello commented 1 year ago

Sure - I'll try it out later this week and see what happens!

vedevilolivedev commented 1 year ago

I went through and replaced api.github.com with our domain/api/v3, and all other github.com to our domain and so far it's seeming to work just fine. Not sure how to automate this though

JarLob commented 19 hours ago

Implemented in f62d32cd684392a758c627a58e0756b734bd54fd