search

GitHubSecurityLab / actions-permissions

GitHub token permissions Monitor and Advisor actions
MIT License
244 stars 19 forks source link

Add mitmproxy certificate authority to Docker configuration #9

Closed remi closed 7 months ago

remi commented 1 year ago

Like #5, let’s add another configuration for another tool 😅 (successfully tested here).

Docker supports custom certificates in /etc/docker/certs.d/<host>:<port> (reference).

GitHub-provided macOS runners do not have Docker running so it’s only for Ubuntu runners.

JarLob commented 1 year ago

Installing CA in the upper directory didn't work out? :(

remi commented 1 year ago

Installing CA in the upper directory didn't work out? :(

Unfortunately no 😞 It looks like a lot of tools out there have their own way of handling CAs…

JarLob commented 1 year ago

I think your changes are good, but I tried to understand if docker doesn't work for everyone, so I have created a test workflow and docker pull and docker build do not fail even without the fix https://github.com/GitHubSecurityLab/actions-permissions/actions/runs/5411765564/jobs/9834933823

Could you help me to understand what is missing to reproduce?