search

GitLabPHP / Client

GitLab API v4 client for PHP
MIT License
932 stars 451 forks source link

[11.11] Fix double encoding of job name in artifacts download #773

Closed wilkolazki closed 11 months ago

wilkolazki commented 1 year ago

I found a bug where methods Jobs::shouldGetArtifactsByRefName and Jobs::shouldGetArtifactByRefName unnecesarily call self::encodePath() to encode query parameters, while all the query parameters are later encoded again in AbstractApi::prepareUri by call to QueryStringBuilder::build().

I've corrected those two methods and modified tests acordingly. I have not checked other methods for similar bugs, but I think it is probable it is there.

GrahamCampbell commented 11 months ago

Thanks.