GitLabPHP / Client

GitLab API v4 client for PHP
MIT License
933 stars 452 forks source link

[11.14] Update `MergeRequests::all` to use millisecond precision #787

Closed janedbal closed 7 months ago

janedbal commented 11 months ago

We are iteratively fetching new MRs via:

updated_after=2023-01-24T18:05:25.801Z
&sort=asc
&order_by=updated_at

And there is more than 100 MR updated within a second. Current implementation causes the same MRs to be analysed again every time. But the API seems to support microsecond precision, so this should fix it.

janedbal commented 11 months ago

Adjusted the formatting:

GrahamCampbell commented 11 months ago

This uses millisecond precision, not microsecond?

janedbal commented 11 months ago

Yes, adjusted title. GitLab API returns datetimes with milliseconds, not micro. So that is probably the best precision we can use.

janedbal commented 10 months ago

@GrahamCampbell any needed changes here?

janedbal commented 10 months ago

ping

GrahamCampbell commented 7 months ago

Thanks.