GitLiveApp / GitLive

GitLive Docs
83 stars 26 forks source link

extension causes terminal problem #163

Closed AdvancedBot closed 1 month ago

AdvancedBot commented 1 month ago

Type: Bug

after bisec i found it is teamhub

Extension version: 18.0.5 VS Code version: Cursor 0.41.1 (10e3716b510a5d447c1a07b2edd37a352bbea4d0, 2024-09-18T07:38:06.522Z) OS version: Windows_NT x64 10.0.22631 Modes:

System Info |Item|Value| |---|---| |CPUs|13th Gen Intel(R) Core(TM) i9-13900HX (32 x 2419)| |GPU Status|2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
vulkan: disabled_off
webgl: enabled
webgl2: enabled
webgpu: enabled| |Load (avg)|undefined| |Memory (System)|13.70GB (6.42GB free)| |Process Argv|| |Screen Reader|no| |VM|0%|
AdvancedBot commented 1 month ago

git live extension

nbransby commented 1 month ago

What's the problem exactly?

omril1 commented 1 month ago

I did bisect as well in vscode to see why I had no intellisense and general slowness, it pointed to this extension, disabling it made vscode much more responsive and intellisense is working again. Is there a way to see what was changed in the latest release?

nbransby commented 1 month ago

@omril1 here are the details of the release: https://blog.git.live/gitlive-18.0-merge-conflict-detection-now-flags-conflicting-changes-in-the-repository-view

I suspect it is the merge conflict detection, either in the repository view or in the editor. Do you have the repository view open when the issue occurs? If you change the left view option for their branches from your working tree to base branch, does that fix the issue? 17275656047735193756311298329409

AdvancedBot commented 1 month ago

What's the problem exactly?

image The reactivating terminal in the bottom left corner keeps spinning.

AdvancedBot commented 1 month ago

When I disable this extension, it won't happen again.

MKlblangenois commented 1 month ago

Same issue on my side, Git live give long time and execution error for terminal, git and other extension error (like Prettier taking 7-8s per task). Disabled Git live solve issue

omril1 commented 1 month ago

After waiting a while and letting the extension to load more the issue is resolved, but I ended up removing it anyway since it shows too much info on hover and there is no option to disable this as far as I can see (there are barely any options at all)

nbransby commented 1 month ago

@omril1 you can disable that via right-click in the gutter.

We are waiting on the vscode team to control the hover verbosity: https://github.com/GitLiveApp/GitLive/issues/150

nbransby commented 1 month ago

@omril1 @MKlblangenois are you able to confirm if you are using vscode insiders or stable?

MKlblangenois commented 1 month ago

@nbransby I use the stable version. I could try with the insider version if you need reproduction ?

image
MKlblangenois commented 1 month ago

@nbransby with the Insider version, I can't reproduce the issue, it seems to work better

nbransby commented 1 month ago

Thanks @MKlblangenois

nbransby commented 1 month ago

Version 18.0.6 of GitLive has now been released which should fix these issues, please let us know if you are still experiencing the issue after updating the extension

xin053 commented 1 month ago

Version 18.0.6 of GitLive still have this problem

nbransby commented 1 month ago

@xin053 can you give more details on the issue you're experiencing exactly?

MP3Martin commented 1 month ago

Version 18.0.6 of GitLive still have this problem

For me, it causes a memory leak of 10+ MB per second

(by not doing anything, just having the extension enabled)

nbransby commented 1 month ago

@MP3Martin do you have any particularly large files in your git repository?

MP3Martin commented 1 month ago

@MP3Martin do you have any particularly large files in your git repository?

no files/tabs open, just the extension enabled disabling the extension fixes my issue

I made the comment just to share some info, i don't need to resolve the issues because i have disabled the extension (i don't use its features that often). My issue might also be caused by an incompatibility with a different extension.

nbransby commented 1 month ago

I made the comment just to share some info,

Thanks. Did the issue occur on an open source repo you are able to share by any chance? Also if you could share the list of extensions you have installed that would help a lot too.

MP3Martin commented 1 month ago

I made the comment just to share some info,

Thanks. Did the issue occur on an open source repo you are able to share by any chance? Also if you could share the list of extensions you have installed that would help a lot too.

Sorry, I've just realized what this extension is for. The issue occurs even with a new window of VSCode that doesn't have any folder/file/repo open.

My extension list is very long.

I've now tried to disable every single extension except GitLive, relaunched VSCode and the issue still happens. I am using default GitLive setting (i don't think there are any)

nbransby commented 1 month ago

The issue occurs even with a new window of VSCode that doesn't have any folder/file/repo open.

That's wild. Do you also see this reactivating terminals message?

Is there anything useful in the output window, under Extension Host or Shared maybe?

nbransby commented 1 month ago

Also if you are able, could you run this command?

image
MP3Martin commented 1 month ago

If it try to run the command quickly, then it maybe works. But if i run it like 10 seconds after opening vscode, the extension is already frozen

image

Edit: if it was supposed to give me something after pressing enter, then it didn't work.

nbransby commented 1 month ago

Edit: if it was supposed to give me something after pressing enter, then it didn't work.

Nvm, It was.

The fact you get it even on the welcome page means it must be something very fundamental that's not working as very little code executes before you have opened a workspace with a git repo in it.

Could you share the logs mentioned in this issue, namely:

Console output (Go to toolbar --> View --> Output, and copy the contents) Log file (Path is printed to the console output at startup)

nbransby commented 1 month ago

Also this would be super useful if you have the time https://github.com/microsoft/vscode/wiki/performance-issues#profile-the-running-extensions

Apologies for all the requests, we've had no luck reproducing this issue and you seem like one of the very few people able to reliably reproduce it

MP3Martin commented 1 month ago

Edit: if it was supposed to give me something after pressing enter, then it didn't work.

Nvm, It was.

The fact you get it even on the welcome page means it must be something very fundamental that's not working as very little code executes before you have opened a workspace with a git repo in it.

Could you share the logs mentioned in this issue, namely:

Console output (Go to toolbar --> View --> Output, and copy the contents) Log file (Path is printed to the console output at startup)

I don't have a "GitLive" option in this "Output" dropdown image (the image doesn't contain all of the dropdown options)

The only path i could find is this: image (When i select "Window" from the dropdown)

This is the content of the automatically generated .cpuprofile : https://gist.githubusercontent.com/MP3Martin/1669bc783b1715bda57cf6d664591efe/raw/4b5e9603e02b0444a6e9cf683f57927ad3e1810d/exthost-7fef10.cpuprofile

MP3Martin commented 1 month ago

Also this would be super useful if you have the time https://github.com/microsoft/vscode/wiki/performance-issues#profile-the-running-extensions

Apologies for all the requests, we've had no luck reproducing this issue and you seem like one of the very few people able to reliably reproduce it

This one is manually recorded: https://gist.githubusercontent.com/MP3Martin/1669bc783b1715bda57cf6d664591efe/raw/dca1e33ae7a5ff600a2103138faee60fcb042150/CPU-20241011T080009.134Z.cpuprofile.txt

MP3Martin commented 1 month ago

Here is also a video of the growing memory usage: (not sped up)

https://github.com/user-attachments/assets/07ea04e2-0026-4a07-8a96-057df0a0fded

nbransby commented 1 month ago

This one is manually recorded:

was this recorded whilst the memory was going up? There is no cpu usage by GtiLive in that profile

MP3Martin commented 1 month ago

This one is manually recorded:

was this recorded whilst the memory was going up? There is no cpu usage by GtiLive in that profile

I wanted to comment to #165, but someone said that it was a duplicate of this issue (#163), so i made my comment here

My problem is memory going up and the extension being frozen, and not a cpu usage problem

nbransby commented 1 month ago

Got it, from my understanding we should still see the some activity on the cpu profile from gitlive though if its code is executing to allocate all that memory.

Does the issue still happen if you install the previous version, 17.1.4?

image
MP3Martin commented 1 month ago

17.1.4 works fine

18.0.5 and 18.0.6 have the issue

nbransby commented 1 month ago

what about 18.0.0...

https://marketplace.visualstudio.com/_apis/public/gallery/publishers/TeamHub/vsextensions/teamhub/18.0.0/vspackage

MP3Martin commented 1 month ago

what about 18.0.0...

https://marketplace.visualstudio.com/_apis/public/gallery/publishers/TeamHub/vsextensions/teamhub/18.0.0/vspackage

image still the same issue

nbransby commented 1 month ago

Could you share the logs mentioned in this issue, namely:

Console output (Go to toolbar --> View --> Output, and copy the contents) Log file (Path is printed to the console output at startup)

Could you share these?

MP3Martin commented 1 month ago

Could you share these?

I don't have a "GitLive" option in the "Output" dropdown

Which dropdown option's content should i share?

nbransby commented 1 month ago

View --> Output also the log file (Path is printed to the console output at startup) Also Help -> Toggle Developer Tools -> Console - if there anything in there thanks

MP3Martin commented 1 month ago

image image

nbransby commented 1 month ago

Could you upload this file?

image
MP3Martin commented 1 month ago

I have already done that here: https://github.com/GitLiveApp/GitLive/issues/163#issuecomment-2406779461 (the last link in that comment)

nbransby commented 1 month ago

That appears to be a different CPU profile to the one mentioned in the logs, didn't you say that one was manually generated?

MP3Martin commented 1 month ago

That appears to be a different CPU profile to the one mentioned in the logs, didn't you say that one was manually generated?

Sorry, i have now edited the comment

auto: https://gist.githubusercontent.com/MP3Martin/1669bc783b1715bda57cf6d664591efe/raw/4b5e9603e02b0444a6e9cf683f57927ad3e1810d/exthost-7fef10.cpuprofile

manual: https://gist.githubusercontent.com/MP3Martin/1669bc783b1715bda57cf6d664591efe/raw/dca1e33ae7a5ff600a2103138faee60fcb042150/CPU-20241011T080009.134Z.cpuprofile.txt

nbransby commented 1 month ago

@MP3Martin thanks, that was useful, can you also reproduce the issue in vscode insiders?

MP3Martin commented 1 month ago

Hello, i can't reproduce the issue in both insiders and vscodium. (with settings sync enabled / profile imported to download the config from normal vscode)

I have also tried to create a new empty profile in my normal VSCode installation (the one where the issue happens), installed just the GitLive extension and i couldn't reproduce the issue.

Then, in the standard version of VSCode, I've created a duplicate (called "Default (Copy)") of the problematic profile (called "Default") image

and the issue was gone.

I don't know why, but creating a duplicate of the current profile and setting the duplicate as the default profile fixes the issue.

nbransby commented 1 month ago

Thanks for trying all that and the detailed explanations, it's much appreciated.

Did GitLive ask you to sign in again on the copy of the default profile? Were you signed in previously with the default profile, for example when you installed 17.1.4 and it was working?

MP3Martin commented 1 month ago

Did GitLive ask you to sign in again on the copy of the default profile?

Were you signed in previously with the default profile, for example when you installed 17.1.4 and it was working?

  • No
MP3Martin commented 1 month ago

So, this is gonna be a little embarrassing

I've just realized that i have been using gitlive and gitlens together

I initially thought that the second extension had features like the git graph, and that this extension included features like this: image

However, I've now realized that all those features are from the second extension, and I misunderstood the purpose of this extension. If I'm the only one having my specific issue (the quick memory usage growing), then you don't have to try to solve my issue anymore, because I've basically never used this extension, it was just installed without any purpose.

I am sorry if i wasted your time

Have a nice day and good luck with everything

nbransby commented 1 month ago

Thats ok, I don't believe you are the only one, thanks for your help!

nbransby commented 1 month ago

@MP3Martin If you are willing to do one last thing - could you share an export of the offending profile to support@gitl.ive to help us reproduce the issue?