search

GitLiveApp / GitLive

GitLive Docs
83 stars 24 forks source link

Can't work on issues with long names, silent exception #85

Closed amogorkon closed 3 years ago

amogorkon commented 3 years ago

I really like the feature of gitlive that encourages feature-branches with the #-name schema and asks the user to pick an issue, which is a great workflow. However, it confused me a great deal when I tried to pick an issue that had slightly longer name than usual (It should be possible to use a package via "package:module", ("package", "module") or kwarg package="package", module="module"). I expected that gitlive would trunkate or at least display an error message, but instead it simply wouldn't comply with me selecting the issue. It worked once I shortened the name. This is a big no-no in UX-design, please fix.

Reedyuk commented 3 years ago

Hi @amogorkon - thanks for the feedback. Can you show me a screenshot of what you mean? Are you saying you see the issue but when you click it, it doesn't do anything? We actually do truncate the length, but maybe we need to adjust this more or maybe a special character is causing the issue.

Reedyuk commented 3 years ago

@amogorkon - i have investigated your issue and was unable to reproduce the issue.

Maybe you could give me some more information on the issue? Can you make sure you have the latest plugin and try again.

Screenshot 2021-09-27 at 16 55 16 Screenshot 2021-09-27 at 16 55 09 Screenshot 2021-09-27 at 16 55 00
amogorkon commented 3 years ago

Strange.. I'll try again and see if I can reproduce with a new, very long issue title.

amogorkon commented 3 years ago

OK, now. The github issue title limit is 256, so I made an issue with exactly that length: https://github.com/amogorkon/justuse/issues/281 It seems to work now, but two other, small issues I noticed with the indicators: the underscores in the title are missing, which probably should be handled like whitespace and just be replaced with single-underscores and no indication of truncation in the status bar. Unbenannt

amogorkon commented 3 years ago

I'll try to replicate the original issue to rule out special character issues..

amogorkon commented 3 years ago

I just noticed that the status bar button is missing where i can select a new issue :-s

amogorkon commented 3 years ago

Alright, I made a new issue: https://github.com/amogorkon/justuse/issues/282 This time, it looks like it's working as it should, also no missing status bar button (even though it's very large and should probably be truncated a few characters past the number like #282 gitlive test[...] Unbenannt

Reedyuk commented 3 years ago

strange that it didn't work first time though, the only thing that i can think of, was you were using an older version of the extension(was several releases back) where i made the change to truncate the issue length.

amogorkon commented 3 years ago

wait a second.. all special characters are missing from the title? Unbenannt

Reedyuk commented 3 years ago

Yes, that is required, otherwise it is not possible to create the git branch.

amogorkon commented 3 years ago

My release now is v14.0.4, if that is of any use. Well, it seems to work now as it should, albeit with a few rough edges. Thanks for your time and keep up the good work :)

Reedyuk commented 3 years ago

Thanks! I'm glad its working now, please raise any other issues you may find. I will close this issue, but re-open it if you find a reproducible example.