Closed fmasa closed 4 months ago
@nbransby The scacap/action-surefire-report
GH action does not play well with PRs opened from forks. Should I try to fix it, or do we drop it altogether? 🤔
Are we using something else for the firebase-kotlin-sdk?
@nbransby For firebase-kotlin-sdk
the test output is only attached to a Job when test failed..
But that is only for other targets. There is no CI running for JVM builds in firebase-kotlin-sdk
🤔
@nbransby For
firebase-kotlin-sdk
the test output is only attached to a Job when test failed..
we can do the same here if thats easiest
But that is only for other targets. There is no CI running for JVM builds in
firebase-kotlin-sdk
🤔
Yeah we probably should add that sometime!
@nbransby I dropped the problematic action. Didn't get to this sooner. :slightly_smiling_face:
PR tests were previously failing because there are currently two tests that both initialize the default Firebase app.
I originally wanted to just use different instance per each test, but FirebaseApp internals always expect that default app exist, so I added a simple cleanup before each test instead.