Fix serialization of value classes

GitLiveApp / firebase-kotlin-sdk

A Kotlin-first SDK for Firebase

https://gitliveapp.github.io/firebase-kotlin-sdk/

Apache License 2.0

1.17k stars 155 forks source link

Fix serialization of value classes #456

Closed fmasa closed 9 months ago

fmasa commented 10 months ago

Hi, thank you for this awesome library!

I'm trying to migrate to this library from my hacky implementation (https://github.com/fmasa/wfrp-master/pull/238) and I encountered the following bug.

Fields with value classes are now always serialized as null, this fixes it.

fmasa commented 9 months ago

Hey 👋 , did anyone had time to take a look? 🙂

Daeda88 commented 9 months ago

@fmasa Im guessing its sort of blocked by my PR, which refactors serialization quite a bit more substantially. To speed up the process, I've added the value class fix in there as well :)

fmasa commented 9 months ago

@Daeda88 Thanks! I figured as much :grinning: