search

GitLiveApp / firebase-kotlin-sdk

A Kotlin-first SDK for Firebase
https://gitliveapp.github.io/firebase-kotlin-sdk/
Apache License 2.0
979 stars 148 forks source link

Add firebase analytics #525

Closed BasBuijsen closed 1 week ago

BasBuijsen commented 3 weeks ago

This PR contains most of the firebase analytics implementation for Android, iOS and JS. This was requested in this recent issue and this very old issues.

For testing, this is very difficult. There is no real way to ensure logs arrived at the firebase side. There is no emulator for analytics and there is no response from the logEvent call to know if it succeeded. For now i only added a test that ensures the analytics object is available and makes sure it doesn't crash when calling the logEvent function. If you have ideas on how to better test this, please let me know!

To create the module i copy pasted one of the previously existing modules. I think i went through all the steps but im not 100% sure i did everything since there is no real guide for adding a new module. Could you let me know wether i added it in all the right places?

BasBuijsen commented 3 weeks ago

@nbransby this is ready for review now. Could you take a look at it when you have the time?

BasBuijsen commented 1 week ago

@nbransby can this be merged? Since the android tests are still flaky :)