search

GitLiveApp / firebase-kotlin-sdk

A Kotlin-first SDK for Firebase
https://gitliveapp.github.io/firebase-kotlin-sdk/
Apache License 2.0
1.17k stars 155 forks source link

Split tests by modules in Github Actions #558

Closed siarhei-luskanau closed 4 months ago

nbransby commented 4 months ago
image

@siarhei-luskanau do you know why these get stuck on waiting for status to be reported?

siarhei-luskanau commented 4 months ago

image @siarhei-luskanau do you know why these get stuck on waiting for status to be reported?

@nbransby I have no idea. Looks like it is related the matrix jobs

nbransby commented 4 months ago

Is there a way to fix that?

siarhei-luskanau commented 4 months ago

Is there a way to fix that?

Probably issue is related the brunch rules https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/managing-protected-branches/about-protected-branches#about-branch-protection-rules

nbransby commented 4 months ago

I don't believe so as it works on other PRs fine - example https://github.com/GitLiveApp/firebase-kotlin-sdk/pull/504

siarhei-luskanau commented 4 months ago

I don't believe so as it works on other PRs fine - example #504

I have found similar issue with Expected — Waiting for status to be reported https://github.com/orgs/community/discussions/26698

nbransby commented 4 months ago

Ok thanks for the extra info, I've fixed that now. There is one failing test which I don't think has anything to do with these changes but would be good to get fixed before merging in:

dev.gitlive.firebase.auth.FirebaseAuthTest.testSignInWithUsernameAndPassword[iosSimulatorArm64] FAILED
    dev.gitlive.firebase.FirebaseNetworkException at /opt/buildAgent/work/b2e1db4d8d903ca4/kotlin/kotlin-native/runtime/src/main/kotlin/kotlin/Throwable.kt:28

Not sure why there is network connection issues with the ios simulator, could it be to do with the Firebase Local Emulator Suite setup?

siarhei-luskanau commented 4 months ago

Ok thanks for the extra info, I've fixed that now. There is one failing test which I don't think has anything to do with these changes but would be good to get fixed before merging in:

dev.gitlive.firebase.auth.FirebaseAuthTest.testSignInWithUsernameAndPassword[iosSimulatorArm64] FAILED
    dev.gitlive.firebase.FirebaseNetworkException at /opt/buildAgent/work/b2e1db4d8d903ca4/kotlin/kotlin-native/runtime/src/main/kotlin/kotlin/Throwable.kt:28

Not sure why there is network connection issues with the ios simulator, could it be to do with the Firebase Local Emulator Suite setup?

It looks like the flaky fails, I didn't changed the Firebase related code. Please re-launch the failed jobs. Result of splitting is re-launching the small piece of flaky failed jobs