making unnecessary http request on every single endpoint??

GitSparTV / discordia-slash

Discordia application commands extension

MIT License

38 stars 13 forks source link

making unnecessary http request on every single endpoint?? #20

Open Bilal2453 opened 1 month ago

Bilal2453 commented 1 month ago

The call this library does self:getApplicationInformation is a very very VERY unnecessary request. It is NEVER cached result wise, and you can simply use self._user._id (or self.user.id) instead of it which is ALWAYS guaranteed to exists and does not require an http request... ON EVERY SINGLE CALL. It is also what Discordia uses internally.

This current behavior also breaks one of the most important rules of Discordia: Do NOT Make Unnecessary Calls Behind The Scenes.

Bilal2453 commented 1 month ago

I won't be able to continue recommending this extension until this one is fixed, it is quite an important detail that I should not have missed. Along with the rest of the opened issues although those are of less criticality.