search

GitSquared / edex-ui

A cross-platform, customizable science fiction terminal emulator with advanced monitoring & touchscreen support.
GNU General Public License v3.0
40.88k stars 2.59k forks source link

Last line cut off on 1.1.1 #302

Closed jajaperson closed 6 years ago

jajaperson commented 6 years ago

Kind of similar to #291 . After upgrading, overflow no longer was visible, but the bottom line on the terminal (e.g. the vim command line) is hidden underneath the keyboard/file system bar.

System: MacOS Sierra Shell: bash

Screen shot of Issue

SerpentChris commented 6 years ago

The same thing happens with 1.1.1 in Mojave for me.

akbiggs commented 6 years ago

I'm running into this issue too. This problem seems to go away if I change the number of rows set in the fix for #291 from "rows+1" to just "rows" here, but I've only tested on OS X currently. I'll build and test with my Windows laptop tomorrow.

@GitSquared What's the reason for this resize, and why "rows+1" instead of "rows"? Should there be a comment to explain what's going on there?

GitSquared commented 6 years ago

@akbiggs It's a bit of a hack because xterm.js' fit addon tends to cut smaller than the actual available size.

I'm wondering if the bug isn't related to you guys having a different screen ratio than 16:9 (i know some macOS devices use 16:10 or whatever), could you confirm this? @SerpentChris @jajaperson

akbiggs commented 6 years ago

Yup, you're right. I'm on a 16:10 display. I'll try hooking my laptop up to a 16:9 display and see what happens.

GitSquared commented 6 years ago

@akbiggs All right. If you confirm that it works as intended on 16:9, i'll make a workaround for this by testing the screen resolution before applying this "fix".

Mind if you give me the exact screen res of your 16:10 display?

akbiggs commented 6 years ago

2880 x 1800

Thanks so much for the speedy responses! This is super cool!!!

jajaperson commented 6 years ago

I'm on a 1440 x 900 (16:10) display.

GitSquared commented 6 years ago

@akbiggs Could you confirm the fix is working?

fsegouin commented 6 years ago

Having the same issue on a 3440x1440 monitor.

eimantasbucys commented 5 years ago

Same issue, using 1.1.2 on 1920x1080 edex-ui

ask-compu commented 5 years ago

Having this issue in Ubuntu 14.04 in windowed mode Screenshot Seems to be fixed if I resize the window in a certain way Screenshot 2

GitSquared commented 5 years ago

@ask-compu This is because only a few aspect ratios are supported by eDEX and the windowed mode isn't locked to any of those. I opened #413 to address this. Thanks for the screenshots.