GitSquared / node-geolite2-redist

Redistribution of MaxMind GeoLite2 GeoIP databases as an npm library
https://gitsquared.github.io/node-geolite2-redist/
Other
72 stars 15 forks source link

Databases can be missing if only one of them needs to be updated #25

Closed GitSquared closed 2 years ago

GitSquared commented 2 years ago

First reported in #24 after this workflow

caub commented 2 years ago

The latest commit https://github.com/GitSquared/node-geolite2-redist/tree/master/redist contains GeoLite2-City.tar.gz, GeoLite2-Country.tar.gz but not GeoLite2-ASN.tar.gz is this normal?

caub commented 2 years ago

can we expect GeoLite2-City.tar.gz to be always in the redist/ directory? (when the issue is fixed)

Thanks for your work btw

caub commented 2 years ago

The latest commit https://github.com/GitSquared/node-geolite2-redist/tree/master/redist contains GeoLite2-City.tar.gz, GeoLite2-Country.tar.gz but not GeoLite2-ASN.tar.gz is this normal?

ASN was missing 1 minute ago

Apparently the CI rewrite the whole git history each time (makes sense since they are large files)

GitSquared commented 2 years ago

@caub good catch 🙈, fixed in this run

I'm looking into fixing the underlying issue which is that all the database files get cleaned out from the git history regardless of which ones are updated. It does that so the git repository doesn't bubble up to a monstruous size over time, but it should not clean out databases that haven't been written back.

can we expect GeoLite2-City.tar.gz to be always in the redist/ directory? (when the issue is fixed)