Argument.IsNotNullOrEmpty(nameof(path), path) thrown

GitTools / GitLink

Making .NET open source accessible!

MIT License

555 stars 86 forks source link

Argument.IsNotNullOrEmpty(nameof(path), path) thrown #207

Open etalon opened 5 years ago

etalon commented 5 years ago

The GetNormalizedPath-Function is called with an empty path. I don't know why an empty path is passed an not filtered.

I tried removing empty paths in Linker.Link-Function and then it worked but I don't want to push this.

I call GitLink.exe with the following arguments: $arguments = $pathToPdb + " --baseDir " + $workingDir + " --url " + $url

PS: A new release would be fine. Thanks for your efforts.

GeertvanHorrik commented 5 years ago

Interested in doing a PR?

etalon commented 5 years ago

Sorry, what is a PR?

GeertvanHorrik commented 5 years ago

PR stands for Pull Request.

etalon commented 5 years ago

Thanks, sure. My changes in the code are working, but I didn't solve the problem from the root. So I don't want to push this. Someone who knows the code in detail can say where these empty paths come from.