Closed dependabot[bot] closed 1 year ago
@AdmiringWorm if/when you have a moment, would you be able to have a look at this PR? Bumping the version of YamlDotNet breaks a couple of tests, specifically, when testing this method:
Which was updated in this PR by yourself:
https://github.com/GitTools/GitReleaseManager/pull/152
The problem seems to lie in the fact that with the change made in this PR, running the failing tests results in this file being created:
Where are previously, it would create this file:
Notice that every line has a #
on it in the second, whereas on the first, it doesn't. Something must have changed with the recent version of YamDotNet, which controls this behaviour, but on looking, I wasn't able to find anything obvious. Any ideas?
Thanks!
Superseded by #522.
@gep13 it almost looks like that YamlDotNet no longer honors the newline used by the Text Writer that we set here: https://github.com/GitTools/GitReleaseManager/blob/develop/src/GitReleaseManager.Core/Configuration/ConfigSerializer.cs#L70
I honestly am not sure how we would even fix that right now.
I'll say that we perhaps ignore this major version until we know how we can fix the commenting on the entire sample configuration?
@AdmiringWorm said... I'll say that we perhaps ignore this major version until we know how we can fix the commenting on the entire sample configuration?
No objections from me.
Depending on when the problem was introduced, we could perhaps go to 12.x, rather then 13.x?
Agreed, which is why I left a comment in the other issue to ignore this major version, this makes dependabot monitor the 12.x (and 14.x) version ranges going forward (if I remember correctly).
Bumps YamlDotNet from 11.2.1 to 13.2.0.
Release notes
Sourced from YamlDotNet's releases.
... (truncated)
Commits
bfba244
Merge pull request #833 from EdwardCooke/ec-sponsors4ac5f87
Added sponsors to bottom of the readme20f17c7
Merge pull request #827 from tymokvo/add-force-scalar-style75e27ac
Merge pull request #832 from FyiurAmron/add_missing_methods_and_reorder3fdeb30
Merge pull request #778 from rutger-dijkstra/fix-block-level-quoted-strings0bb66ea
added requested test cases592acc7
Rearrange constructor order030a2cf
Remove argument name58985b3
Add newline0d0124f
Add specific scalar styling constructorsDependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show