GitTools / GitReleaseManager

Tool for creating and exporting releases for software applications hosted on GitHub
https://gittools.github.io/GitReleaseManager/docs/
MIT License
304 stars 39 forks source link

Bump YamlDotNet from 11.2.1 to 13.2.0 in /src #506

Closed dependabot[bot] closed 1 year ago

dependabot[bot] commented 1 year ago

Bumps YamlDotNet from 11.2.1 to 13.2.0.

Release notes

Sourced from YamlDotNet's releases.

Release 13.2.0

  • Merge pull request #821 from rudolfolah/deserialize-generic-objects-error-message-and-sample
    Deserialize generic objects sample

  • Merge pull request #825 from rbnswartz/rs/optimization-for-scanner
    Use a span to reduce string allocations

  • Merge pull request #782 from hemnstill/mergingparser_with_aliases_try2
    MergingParser deserializer can now handle nested NodeSequence with aliases (try2)

  • Merge pull request #778 from rutger-dijkstra/fix-block-level-quoted-strings
    Quoted scalars are flow scalars only if flowLevel > 0

  • Merge pull request #832 from FyiurAmron/add_missing_methods_and_reorder
    Add missing methods to (de)serializer interfaces and implementations

  • Merge pull request #827 from tymokvo/add-force-scalar-style
    Add default scalar style

Release 13.1.1

  • Merge pull request #814 from YihaoOct/yihao/fix-comments
    Fix Emitter to handle comments between a mapping key and a mapping/sequence value

Release 13.1.0

  • Merge pull request #774 from JJ11teen/buffered-deserialisation
    Buffered deserialisation

Release 13.0.2

  • Fixed static tests so the pass in linux

  • Merge pull request #786 from meziantou/fix-nullable
    Fix NRT for ISerializer

  • Merge pull request #787 from meziantou/fix-nrt-ipropertydescriptor
    Fix nullable annotations for IPropertyDescriptor.GetCustomAttribute

  • Merge pull request #788 from EdwardCooke/ec-740-nested
    Support nested classes in the static code generator

Release 13.0.1

  • Made pushing the serializer optional

  • Merge pull request #780 from hemnstill/mergingparser_with_aliases
    MergingParser deserializer can now handle nested NodeSequence + tests

Release 13.0.0

  • Merge pull request #769 from EdwardCooke/ec-fix-304
    Special named enums get taken into account with quotingneccesarystrings

  • Merge pull request #768 from EdwardCooke/ec-fix-587

... (truncated)

Commits
  • bfba244 Merge pull request #833 from EdwardCooke/ec-sponsors
  • 4ac5f87 Added sponsors to bottom of the readme
  • 20f17c7 Merge pull request #827 from tymokvo/add-force-scalar-style
  • 75e27ac Merge pull request #832 from FyiurAmron/add_missing_methods_and_reorder
  • 3fdeb30 Merge pull request #778 from rutger-dijkstra/fix-block-level-quoted-strings
  • 0bb66ea added requested test cases
  • 592acc7 Rearrange constructor order
  • 030a2cf Remove argument name
  • 58985b3 Add newline
  • 0d0124f Add specific scalar styling constructors
  • Additional commits viewable in compare view


Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)
gep13 commented 1 year ago

@AdmiringWorm if/when you have a moment, would you be able to have a look at this PR? Bumping the version of YamlDotNet breaks a couple of tests, specifically, when testing this method:

https://github.com/GitTools/GitReleaseManager/blob/develop/src/GitReleaseManager.Core/Configuration/ConfigSerializer.cs#L38-L48

Which was updated in this PR by yourself:

https://github.com/GitTools/GitReleaseManager/pull/152

The problem seems to lie in the fact that with the change made in this PR, running the failing tests results in this file being created:

image

Where are previously, it would create this file:

image

Notice that every line has a # on it in the second, whereas on the first, it doesn't. Something must have changed with the recent version of YamDotNet, which controls this behaviour, but on looking, I wasn't able to find anything obvious. Any ideas?

Thanks!

dependabot[bot] commented 1 year ago

Superseded by #522.

AdmiringWorm commented 1 year ago

@gep13 it almost looks like that YamlDotNet no longer honors the newline used by the Text Writer that we set here: https://github.com/GitTools/GitReleaseManager/blob/develop/src/GitReleaseManager.Core/Configuration/ConfigSerializer.cs#L70

I honestly am not sure how we would even fix that right now.

AdmiringWorm commented 1 year ago

I'll say that we perhaps ignore this major version until we know how we can fix the commenting on the entire sample configuration?

gep13 commented 1 year ago

@AdmiringWorm said... I'll say that we perhaps ignore this major version until we know how we can fix the commenting on the entire sample configuration?

No objections from me.

gep13 commented 1 year ago

Depending on when the problem was introduced, we could perhaps go to 12.x, rather then 13.x?

AdmiringWorm commented 1 year ago

Agreed, which is why I left a comment in the other issue to ignore this major version, this makes dependabot monitor the 12.x (and 14.x) version ranges going forward (if I remember correctly).