GitTools / GitReleaseManager

Tool for creating and exporting releases for software applications hosted on GitHub
https://gittools.github.io/GitReleaseManager/docs/
MIT License
298 stars 39 forks source link

An exception is thrown when issue has labels in include and exclude list #574

Closed AdmiringWorm closed 3 months ago

AdmiringWorm commented 4 months ago

Description

Whet attempting to draft a new release, and one or more issues has multiple labels specified where one of the labels is in the include list, and a different label is in the exclude list GRM is throwing an exception making drafting of the release unable to proceed.

Expected Behavior

I would expect the exclude list to take precedence of anything specified in the include list, and issues with any label in the exclude list would be excluded from the drafted release notes.

Actual Behavior

An exception is thrown and aborts the release draft.

Possible Fix

Before throwing an exception, check if any of the labels specified in the exclude list is present. If it is then continue to the next issue without further processing.

Steps to Reproduce

  1. Create a new issue, and add a label from the include and exclude list.
  2. Attempt to draft a new release
  3. Notice the exception

Context

Quite often we have all issues labeled with one of the labels in the include list, and have a very specific label to exclude them from the release notes. Since this is not working, we always have to remove one of the labels and re-apply them after drafting the release notes.

Your Environment

gittools-bot commented 3 months ago

:tada: This issue has been resolved in version 0.17.0 :tada:

The release is available on:

Your GitReleaseManager bot :package::rocket: