GitTools / GitReleaseManager

Tool for creating and exporting releases for software applications hosted on GitHub
https://gittools.github.io/GitReleaseManager/docs/
MIT License
298 stars 39 forks source link

(#476) Add validation of input file path handler #577

Closed AdmiringWorm closed 4 months ago

AdmiringWorm commented 4 months ago

Description

This updates how arguments are parsed when attempting to create a new release. This disallows explicitly the use of a milestone, and an input file path in the same call.

Related Issue

fixes #476

Motivation and Context

This is done as there was confusion on why specifying a input file path was not using the release notes specified. This should make it clearer to the caller what the issue is.

How Has This Been Tested?

  1. Run grm create --milestone 0.5.0 -i some-relase-notes.txt with additional valid arguments.
  2. Ensure an exception is thrown explaining that these two arguments can not be used together.

Screenshots (if appropriate):

Checklist:

gep13 commented 4 months ago

@AdmiringWorm thank you very much for taking the time to fix this up!