GitTools / GitReleaseManager

Tool for creating and exporting releases for software applications hosted on GitHub
https://gittools.github.io/GitReleaseManager/docs/
MIT License
298 stars 39 forks source link

(#578) Bump Octokit to 10.0.0 to fix oversized ints #579

Closed DavidBoike closed 3 months ago

DavidBoike commented 3 months ago

Description

Bumped Octokit to 10.0.0 to solve https://github.com/GitTools/GitReleaseManager/issues/578

Related Issue

https://github.com/GitTools/GitReleaseManager/issues/578

Motivation and Context

https://github.com/GitTools/GitReleaseManager/issues/578 prevents issue data from being fetched from GitHub due to issue/PR Id values that were previously int now being long.

How Has This Been Tested?

Not sure testing this is really possible or appropriate. GitReleaseManager doesn't need the issue Id but the deserialization of the Issue data fails without the fix.

I did grab the CI-created NuGet package to test within our own environment to make sure it fixes the bug for us. That is not yet complete.

Screenshots (if appropriate):

Checklist:

danielmarbach commented 3 months ago

@gep13 sorry to bother you. It would be great to get a review and a release on this one.

danielmarbach commented 3 months ago

I added a fix to my fork and sent in a PR to @DavidBoike https://github.com/DavidBoike/GitReleaseManager/pull/1

danielmarbach commented 3 months ago

Verified that this version gets us unblocked. We are currently using a preview build of this branch

gep13 commented 3 months ago

@DavidBoike thank you very much for raising this PR, it is much appreciated.

Thanks to @danielmarbach and @arturcic for taking this for a spin, and verifying that this fixes the upstream issue in Octokit.

gep13 commented 3 months ago

@DavidBoike thanks again for getting this fixed up!