Closed mentthew-pjwstk closed 3 years ago
Sure, pull requests welcome.
@asbjornu I think a better idea would be not to add a new sdk to the list every time one is requested, but better to check whether the Sdk
attribute has the Microsoft.NET.Sdk
prefix in the attribute value. What do you think?
That would indeed be an improvement, @arturcic! 👍🏼
:tada: This issue has been resolved in version 5.8.0 :tada: The release is available on:
Your GitReleaseManager bot :package::rocket:
Currently supported project SDKs:
I think there should also be added Microsoft.NET.Sdk.BlazorWebAssembly
In file https://github.com/GitTools/GitVersion/blob/e41cc2b69a7723ce43c5f54885973bd5f738eee5/src/GitVersion.Core/VersionConverters/AssemblyInfo/ProjectFileUpdater.cs we can extend supportedSdks array: var supportedSdks = new[] { "Microsoft.NET.Sdk", "Microsoft.NET.Sdk.Web", "Microsoft.NET.Sdk.WindowsDesktop", "Microsoft.NET.Sdk.Razor", "Microsoft.NET.Sdk.Worker", "Microsoft.NET.Sdk.BlazorWebAssembly" };