GitbookIO / filterable

Parse and convert GitHub-like search queries in Node.JS
Apache License 2.0
61 stars 8 forks source link

Possible inconstancies in operator inversion #9

Closed estilles closed 9 years ago

estilles commented 9 years ago

While working on a PR for issue #8 if found what I believe are inconstancies in the way some comparison operators are inverted. For example: >= inverts to <=, I posit it should invert to <. The way I see it >= is inclusive of the value its comparing, therefore the inverted operator should not, hence < and not <= (which does).

The following should be corrected:

Operator Currently Inverts to Should invert to
>= <= <
> < <=
<= >= >
< > >=

If you agree I will submit a PR correcting this.

SamyPesse commented 9 years ago

Fixed by #10