search

GitbookIO / gitbook

The open source frontend for GitBook doc sites
https://www.gitbook.com
GNU General Public License v3.0
26.51k stars 3.81k forks source link

Add German Locale support #2317

Open burghoffdavid opened 2 weeks ago

burghoffdavid commented 2 weeks ago

Hi, I've added German locale support for GitBook.

Link to Diskussion: https://github.com/orgs/GitbookIO/discussions/537

burghoffdavid commented 2 weeks ago

@addisonschultz

burghoffdavid commented 5 days ago

I just noticed that I did not import the new locale file inside src/intl/translations/index.ts to add it to the languages var. Should this be added with this PR or will it be added further down the line by the team?

addisonschultz commented 4 days ago

@burghoffdavid Could you please add the translation import in? Thank you!

burghoffdavid commented 4 days ago

@addisonschultz Done :heavy_check_mark:

burghoffdavid commented 4 days ago

@addisonschultz Not entirely sure why the typecheck CI is failing, any ideas?

addisonschultz commented 4 days ago

@burghoffdavid yep - I've got to add these types to our backend schema - working on that now 😄