GitbookIO / gitbook

The open source frontend for GitBook doc sites
https://www.gitbook.com
GNU General Public License v3.0
27.23k stars 3.88k forks source link

Adds missing css variables #2558

Closed antlio closed 5 days ago

antlio commented 1 month ago

This PR adds missing css variables in the scalar.css stylesheet in order to fix the missing selection style as seen below. The chosen color background respect the default one as close as possible, as seen below:

before / after:

image image image image
changeset-bot[bot] commented 1 month ago

🦋 Changeset detected

Latest commit: c42565826b789628aa731a3c86d8fd273d735580

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package | Name | Type | | ------- | ----- | | gitbook | Patch |

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

amritk commented 2 weeks ago

@SamyPesse any idea why this is failing?

hwkr commented 2 weeks ago

Oh oops I thought this was Scalar 😂 @antlio you're doing great 🫡