GitbookIO / gitbook

The open source frontend for GitBook doc sites
https://www.gitbook.com
GNU General Public License v3.0
27.23k stars 3.88k forks source link

Get the best possible target space for content refs #2580

Open taranvohra opened 2 days ago

taranvohra commented 2 days ago

Fixes RND-5602

changeset-bot[bot] commented 2 days ago

⚠️ No Changeset found

Latest commit: ab726589ec62633bcdb1f09c909442190ce64e49

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

github-actions[bot] commented 2 days ago

GitBook Preview Latest commit: https://1966c86f.gitbook-open.pages.dev PR: https://pr2580.gitbook-open.pages.dev

argos-ci[bot] commented 2 days ago

The latest updates on your projects. Learn more about Argos notifications ↗︎

Build Status Details Updated (UTC)
default (Inspect) 👎 Changes rejected 32 changed, 8 added Nov 22, 2024, 12:09 PM
linear[bot] commented 2 days ago

RND-5602 If spaces are published in 2 different sites with section, relative links between them take you to the other site

SamyPesse commented 2 days ago

Does this solution work in the context of a content-ref to a page in another space (that is published in 2 sites)?

Are we computing the url of the page from the space url or are we using the published url on the page itself from the API?