search

GitbookIO / integrations

Toolkit to build integrations on GitBook
74 stars 42 forks source link

Feature request: Extend fathom integration to track external links #450

Open KevinRohn opened 5 months ago

KevinRohn commented 5 months ago

Description

We use the Fathom integration for analytics on our GitBook pages. Currently, the functionality is limited to tracking only internal site links. However, Fathom also offers an "events" feature, which could be useful for tracking external link clicks.

I attempted to create an integration myself, but it requires script injection. Unfortunately, this functionality is not supported for private integrations.

It would be beneficial to support tracking events for external links. For more information, see Fathom's documentation on events.

Thank you in advance

addisonschultz commented 5 months ago

Hi @KevinRohn! Great feature request, and even nicer that you've already tried to build an integration for this. You are right in that we don't allow the script injection scope to be published, but if you would be interested in opening up a PR in this repo that would update the current Fathom integration, I'd be happy to review and test, and update the current integration if it's working well.

Let me know if that sounds interesting to you, and we can work on it!t

KevinRohn commented 5 months ago

Hi @addisonschultz, I would like to do this, but how can I test it before if I can not inject a script?

Should it work with the execution of the cmd gitbook dev <spaceID> ?

addisonschultz commented 5 months ago

I will need to grant access - but before that, I am able to test if you are able to submit a PR!

KevinRohn commented 2 weeks ago

Hi @addisonschultz,

sorry, rather later than never :) . I opened an PR https://github.com/GitbookIO/integrations/pull/534