GitbookIO / kramed

A markdown (kramdown compatible) parser and compiler. Built for speed. (Fork of marked)
MIT License
223 stars 47 forks source link

Kramdown Class Support #18

Open skyout opened 9 years ago

skyout commented 9 years ago

Classes are not being parsed from Kramdown:

This following kramdown:

> text content
{: .class1 .class2 }

should output:

<blockquote class="class1 class2">text content</blockquote>

but instead is outputting:

 <blockquote>text content {: .class1 .class2  }</blockquote>

It should set the classes on the preceding element and not include the markdown class declaration in the content.

On a possibly related note, I am still seeing issue #4 rendering incorrectly while using version 0.4.6.

AaronO commented 9 years ago

@slanningGH The next kramed release simplifies the internal code, which will make it easier to add full kramdown support, see: https://github.com/GitbookIO/kramed/issues/14#issuecomment-97433880

4 Shouldn't happen, can you share code that triggers that behavior so we can it to the tests ?

skyout commented 9 years ago

I can reproduce #4 with the following code:

# h1 {#class}

this outputs

<h1 id="h1-class-">h1 {#class}</h1>

also, every h1, h2, h3 and so on that I am seeing is setting an ID that matches the content

# This is a header

this outputs

<h1 id="this-is-a-header">This is a header</h1>
signorekai commented 8 years ago

Can I know if class support has been added?

AlexanderKozhevin commented 5 years ago

+1

AndiKod commented 1 year ago

2023, installed the package precisely for this, and it looks like the project is no more maintained ...and the main benefit expected (aka Kramdown) will never be available. :(

chocmake commented 7 months ago

2023, installed the package precisely for this, and it looks like the project is no more maintained ...and the main benefit expected (aka Kramdown) will never be available. :(

That's a pity. Kramdown inline attributes and classes/ids are the key distinguishing advantage of kramdown but from searching around it appears there isn't a Javascript implementation in any Markdown parser to date.

Was looking around for a potential way to augment Jekyll with a solely JS based approach, since a JS implementation of Liquid exists.