remove note about github token being optional

GitbookIO / nuts

:chestnut: Releases/downloads server with auto-updater and GitHub as a backend

http://nuts.gitbook.com

Apache License 2.0

1.25k stars 299 forks source link

remove note about github token being optional #129

Closed zeke closed 6 years ago

zeke commented 7 years ago

If you don't specify process.env.GITHUB_TOKEN, then the server crashes with an error. See https://github.com/GitbookIO/nuts/issues/76

This PR removes a comment from the guide that suggests the token is optional.

zeke commented 7 years ago

bump

zeke commented 7 years ago

'nother bump

AaronO commented 7 years ago

@zeke Rather than removing the sentence saying that it's optional, maybe we should replace it with a sentence explaining why it's required, that otherwise they'll hit GitHub's low API request limit (for unauthenticated API calls) and won't be able to use nuts on private repos.

What do you think ?

zeke commented 6 years ago

Not using nuts after all, so I'm going to close this.