GitbookIO / plugin-mathjax

MathJAX plugin for GitBook
Apache License 2.0
89 stars 51 forks source link

upgrade to 2.6 #19

Closed nagim closed 8 years ago

nagim commented 8 years ago

Hi,

There is a bug in the <2.6 mathjax versions, where there's a trailing | rendered in Chrome at the end of the formulas. An upgrade to 2.6 would eliminate the issue (and the need to hide it with CSS rules).

Thanks, Imre

SamyPesse commented 8 years ago

The last version of the plugin uses MathJax 2.6, you can even configure it: https://github.com/GitbookIO/plugin-mathjax/blob/master/package.json#L34

nagim commented 8 years ago

Thanks, I will try to force the version, because if I check the formula in the browser, it reports mathjax 2.5.3.

nagim commented 8 years ago

Tried to force the version, but from the build log, it seems that v2.5.1 is used despite of that:

info: install plugin mathjax from npm (gitbook-plugin-mathjax) with version 1.0.2 
make: Entering directory `/tmp/book/node_modules/gitbook-plugin-mathjax/node_modules/MathJax-node/node_modules/jsdom/node_modules/contextify/build'
  CXX(target) Release/obj.target/contextify/src/contextify.o
  SOLINK_MODULE(target) Release/obj.target/contextify.node
  SOLINK_MODULE(target) Release/obj.target/contextify.node: Finished
  COPY Release/contextify.node
make: Leaving directory `/tmp/book/node_modules/gitbook-plugin-mathjax/node_modules/MathJax-node/node_modules/jsdom/node_modules/contextify/build'
gitbook-plugin-mathjax@1.0.2 node_modules/gitbook-plugin-mathjax
├── crc@3.2.1
├── q@1.1.2
└── MathJax-node@0.3.0 (yargs@4.7.0, speech-rule-engine@0.9.2, MathJax@2.5.1-mjnode, jsdom@3.1.1)

Was using GitBook 2.6.7.

pkra commented 8 years ago

Just a side note: MathJax-node was renamed mathjax-node a while back (and thus is stuck at 0.3 whereas mathjax-node is at 0.5.1).

nagim commented 8 years ago

@SamyPesse, could you please merge the #20 PR regarding the package name/version, so we can use the latest?

Thanks a lot!

Cheers, Imre