Prism highlighting does not update all lines when changing syntax - Githubissues

GitbookIO / slate-edit-code

A Slate plugin for code block editing

https://gitbookio.github.io/slate-edit-code/

Apache License 2.0

43 stars 34 forks source link

Prism highlighting does not update all lines when changing syntax #17

Closed echenley closed 7 years ago

echenley commented 7 years ago

This probably has something to do with the lines refactor: https://github.com/GitbookIO/slate-edit-code/pull/10. The more basic Slate code-highlighting example does not have this issue: http://slatejs.org/#/code-highlighting

Steps to Reproduce

open a document on gitbook.com
make a code block with
```
var line1;
var line2;
```
change syntax to javascript, then to css
only currently focused line is updated
if you focus the beginning of the incorrectly highlighted line, it triggers prism to update it
if you focus the end of the incorrectly highlighted line, it throws an error

Soreine commented 7 years ago

Fixed in https://github.com/GitbookIO/slate-prism/pull/5