search

GitoxideLabs / gitoxide

An idiomatic, lean, fast & safe pure Rust implementation of Git
Apache License 2.0
8.91k stars 303 forks source link

Rename to `GIT_HIGHEST_SCOPE_CONFIG_PATH` #1569

Closed EliahKagan closed 1 month ago

EliahKagan commented 1 month ago

This renames the crate-internal static item with the cached path of the highest scope nonempty config, treated as associated with the git installation, from GIT_HIGHEST_PRIORITY_CONFIG_PATH to GIT_HIGHEST_SCOPE_CONFIG_PATH.

This reflects the propensity of "priority" to have the opposite of the intended meaning here, since configuration in this file stands to be superseded by configuration in any lower (i.e. any other) scope. See #1568 for context.

I think this change from "PRIORITY" to "SCOPE" in the name preserves the benefits of the change from EXE_INFO to GIT_HIGHEST_PRIORITY_CONFIG_PATH (dd2d666), while making clearer what is going on and avoiding misinterpretations.

EliahKagan commented 1 month ago

Thanks a lot - naming is hard 🤦‍♂️

Yes, and I'm not sure this one is the best possible name either. If I think of something better, I'll let you know!